Fix issue with updating when targeting Nougat or higher #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue was in `plugin.xml`; it had the android:authorities attribute set to 'com.vaenow.appupdate.android.provider.$(appliction_id}`. But, in the code in `DownloadHandler.java` the provider was set to `com.vaenow.appupdate.android.provider`.
|
Awsome @LanceJenkinZA 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request mainly fixes an issue when targeting Nougat.
The authorities section in of the provider tag in plugin.xml was set to
"com.vaenow.appupdate.android.provider.${applicationId}". However, in DownloadHandler.java, the plugin was callingcom.vaenow.appupdate.android.provider.I changed plugin.xml.
I also updated the Javascript function to be called without success or error callback functions (to be compatible with ionic-native).