Fix: datetime64 arithmetics with a constant #1017
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maartenbreddels
force-pushed
the
master
branch
from
49aa65c
to
9289005
Compare
|
I dont think we can fix this, since NumPy gets a first try to perform this operation (the subtract), and fails, we don't get a chance. Possibly we could solve this with NEP13/18, should we look into this? |
maartenbreddels
force-pushed
the
master
branch
from
369423b
to
6927b35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the subtraction a datetime64 expression from a constant np.datetime64 values.
Note: the reverse works, i.e. subtracting a constant np.datetime64 value from a datetime expression works well. The test is included for completeness.