-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vaex-graphql package update. #1325
base: master
Are you sure you want to change the base?
Conversation
It's lacking some integration tests. |
I will make more tests. |
The tests of the original repository in Docker are failing on my machine too, so I reopened in the case of problems are in the test. |
Hi Guilherme, thanks for opening the PR. So your idea if to use a more modern graphene, and take out the tornado part? I'm ok with that, and I wonder if we need to put any version constraint on graphene at all. cheers, Maarten |
A different solution would be to keep the code in, but not require vaex/packages/vaex-core/vaex/dataset.py Line 21 in 5dc29ed
optional_import
|
Hi Maarten, I made a provisional solution, upgrading the vaex-graphql to use the query function to integrate on my Django 3.2 stack. My objective is to contribute the upgrade to vaex-graphql codebase so, in the future, I can just install a compatible version of vaex-graphql instead of using my provisional repo on https://github.com/gmcbretas/vaex-gql-schema. cheers, Guilherme |
I will be happy, and I hope other people with the same problem too, if it works in my environment, I will copy here my Pipenv file contents:
|
369423b
to
6927b35
Compare
Added compatibility with graphene>=3.0b7.