Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vaex-graphql package update. #1325

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

gmcbretas
Copy link

Added compatibility with graphene>=3.0b7.

@gmcbretas gmcbretas closed this Apr 22, 2021
@gmcbretas
Copy link
Author

It's lacking some integration tests.

@gmcbretas gmcbretas reopened this Apr 23, 2021
@gmcbretas gmcbretas closed this Apr 23, 2021
@gmcbretas
Copy link
Author

I will make more tests.

@gmcbretas
Copy link
Author

The tests of the original repository in Docker are failing on my machine too, so I reopened in the case of problems are in the test.

@gmcbretas gmcbretas reopened this Apr 23, 2021
@maartenbreddels
Copy link
Member

Hi Guilherme,

thanks for opening the PR. So your idea if to use a more modern graphene, and take out the tornado part?

I'm ok with that, and I wonder if we need to put any version constraint on graphene at all.

cheers,

Maarten

@maartenbreddels
Copy link
Member

A different solution would be to keep the code in, but not require graphene-tornado. So that users can still install graphene-tornado if they want to run that. See

blake3 = vaex.utils.optional_import('blake3')
for the usage of optional_import

@gmcbretas
Copy link
Author

cheers,

Hi Maarten,

I made a provisional solution, upgrading the vaex-graphql to use the query function to integrate on my Django 3.2 stack. My objective is to contribute the upgrade to vaex-graphql codebase so, in the future, I can just install a compatible version of vaex-graphql instead of using my provisional repo on https://github.com/gmcbretas/vaex-gql-schema.

cheers,

Guilherme

@gmcbretas
Copy link
Author

gmcbretas commented Apr 23, 2021

A different solution would be to keep the code in, but not require graphene-tornado. So that users can still install graphene-tornado if they want to run that. See

blake3 = vaex.utils.optional_import('blake3')

for the usage of optional_import

I will be happy, and I hope other people with the same problem too, if it works in my environment, I will copy here my Pipenv file contents:

[[source]]
name = "pypi"
url = "https://pypi.org/simple"
verify_ssl = true

[dev-packages]

[packages]
autopep8 = "*"
attrs = "*"
backcall = "*"
certifi = "*"
chardet = "*"
decorator = "*"
django-environ = "*"
django-extensions = "*"
django-pandas = "*"
django-redis = "*"
flake8 = "*"
flake8-commas = "*"
flake8-mypy = "*"
gevent = "*"
greenlet = "*"
gunicorn = "*"
idna = "*"
ipython = "*"
jedi = "*"
mccabe = "*"
mypy = "*"
parso = "*"
pexpect = "*"
pickleshare = "*"
prompt-toolkit = "*"
psycopg2-binary = "*"
ptyprocess = "*"
pycodestyle = "*"
pyflakes = "*"
pytz = "*"
redis = "*"
requests = "*"
rope = "*"
simplegeneric = "*"
six = "*"
traitlets = "*"
typed-ast = "*"
urllib3 = "*"
wcwidth = "*"
raven = "*"
django-graphql-jwt = "*"
graphene = "*"
graphene-django = "*"
Django = "*"
ipython_genutils = "*"
Pillow = "*"
Pygments = "*"
Werkzeug = "*"
pandas = "*"
yahooquery = "*"
openpyxl  = "*"
django-filter = "*"
pandas-datareader = "*"
celery = "*"
plotly = "*"
sklearn = "*"
tensorflow = "*"
keras = "*"
selenium = "*"
html5lib = "*"
beautifulsoup4 = "*"
vaex = "*"
vaex-ml = "*"
vaex-gql-schema = {editable = true,git = "https://github.com/gmcbretas/vaex-gql-schema"}

[requires]
python_version = "3.8"

[pipenv]
allow_prereleases = true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants