🐎 use binners to compute 1d index #1642
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maartenbreddels
force-pushed
the
master
branch
from
369423b
to
6927b35
Compare
This should speed up computations, since we don't go in and out of numpy. We also use the binner more consistently throughout. Also, this should allow for GrouperLimited, and Binner to be used with _combine.
maartenbreddels
force-pushed
the
perf_groupby_combine
branch
from
ed57a55
to
c90a516
Compare
this will be more cache friendly, since a tighter loop in c++ However, performance isn't great because expressions are always evaluated with all threads enabled. A future refactor may make better use of this.
maartenbreddels
force-pushed
the
perf_groupby_combine
branch
from
c90a516
to
943e2f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should speed up computations, since we don't go in and out of
numpy. We also use the binner more consistently throughout.
Also, this should allow for GrouperLimited, and Binner
to be used with _combine.