Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: configure logging using settings system #1811

Merged
merged 3 commits into from Jan 10, 2022
Merged

feat: configure logging using settings system #1811

merged 3 commits into from Jan 10, 2022

Conversation

maartenbreddels
Copy link
Member

We also use Rich to have beautiful default logging to console. This can be disabled using the settings.
image

@maartenbreddels maartenbreddels force-pushed the feat_configure_logging branch 2 times, most recently from d9cbd8e to 7ebb2b2 Compare January 4, 2022 10:00
JovanVeljanoski
JovanVeljanoski approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@JovanVeljanoski JovanVeljanoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
I like the removal of some py2 leftovers :)

@maartenbreddels
Copy link
Member Author

yeah, did some extra cleanups :)

@maartenbreddels maartenbreddels merged commit 1039f80 into master Jan 10, 2022
@maartenbreddels maartenbreddels mentioned this pull request Jan 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JovanVeljanoski JovanVeljanoski JovanVeljanoski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maartenbreddels @JovanVeljanoski