Fix: reliable export hdf5 with small chunks size #2280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maartenbreddels
force-pushed
the
fix_export_hdf5_small_chunks
branch
from
64391b6
to
717ea40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some issues we've encountered with exporting some type of data to hdf5. The unit-tests have been scaled the reproduce the issues via minimal data, but the same issues are encountered with the
default_chunk_sizeon larger datasets.I suspect this is due to a combination of
chunk_sizeand amount of missing/masked values in a particular chunk.I do not know the exact origin of the errors at this point, so the tests have rather generic names.
Each of the unit-tests raises a different error, which is why I created separate tests rather than one in which the amount of data is varied.
Exporting the same data under the same conditions (i.e.
chunk_size) to arrow or parquet format works just fine.Checklist: