Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add types to get_column_names #813

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xdssio
Copy link
Collaborator

@xdssio xdssio commented Jun 8, 2020

  1. Add a dtypes param to get_column_names
  2. Add this type to the getitem method for a quick shortcut.

example:

>>> from vaex.ml.datasets import load_titanic
>>> df = load_titanic()

>>> df.get_column_names(dtypes=int)
['pclass', 'sibsp', 'parch']

>>> df.get_column_names(dtypes=[bool, int])
['pclass', 'survived', 'sibsp', 'parch']

>>> df[int].get_column_names()
['pclass', 'sibsp', 'parch']

>>>df[bool, int].get_column_names()
['pclass', 'survived', 'sibsp', 'parch']

@JovanVeljanoski
Copy link
Member

Can this PR be revisited given the new developements of dtype in vaex @maartenbreddels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants