Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement foreign language-only filter for opensubtitles #486

Merged

Conversation

vagabondHustler
Copy link
Owner

  • Added logic for subtitle type selection based on user preferences
  • Introduced options for hearing-impaired-only, foreign-parts-only, and both
  • Updated CreateProviderUrls class to handle different subtitle types
  • Modified the logic for generating search parameters based on subtitle type
  • Created a new method subtitle_type_logic to determine subtitle type combinations

- Added logic for subtitle type selection based on user preferences
- Introduced options for hearing-impaired-only, foreign-parts-only, and both
- Updated `CreateProviderUrls` class to handle different subtitle types
- Modified the logic for generating search parameters based on subtitle type
- Created a new method `subtitle_type_logic` to determine subtitle type combinations
@vagabondHustler vagabondHustler added the feat A new feature label Aug 21, 2023
@vagabondHustler vagabondHustler changed the title Feat add foreign parts only search to OpenSubtitles Implement foreign language-only filter for opensubtitles Aug 21, 2023
@vagabondHustler vagabondHustler self-assigned this Aug 21, 2023
@vagabondHustler vagabondHustler marked this pull request as ready for review August 29, 2023 20:21
@vagabondHustler vagabondHustler merged commit fa2d376 into main Aug 29, 2023
3 checks passed
@vagabondHustler vagabondHustler deleted the feature/foreign_parts_only_opensubtitles/230821200724 branch August 29, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant