Support dev setting vagrant-spec version from env #1344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow control of the reference or version of vagrant-spec to be used from the dev environment where it is necessary to test with older versions of the plugin which may depend on different versions of dependencies compared to vagrant-spec. In this case the latest vagrant-spec has rolled forward the rspec core version to 3.10, which works with the latest vagrant-libvirt. However previous versions of vagrant-libvirt require 3.5, which was the previous minor version pinned. Adding the option of VAGRANT_SPEC_VERSION that can be set as an environment variable should help control this explicitly when needed in the future the same as how VAGRANT_VERSION is handled.
mmguero
pushed a commit
to mmguero-dev/vagrant-libvirt
that referenced
this pull request
Sep 13, 2021
Allow control of the reference or version of vagrant-spec to be used from the dev environment where it is necessary to test with older versions of the plugin which may depend on different versions of dependencies compared to vagrant-spec. In this case the latest vagrant-spec has rolled forward the rspec core version to 3.10, which works with the latest vagrant-libvirt. However previous versions of vagrant-libvirt require 3.5, which was the previous minor version pinned. Adding the option of VAGRANT_SPEC_VERSION that can be set as an environment variable should help control this explicitly when needed in the future the same as how VAGRANT_VERSION is handled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow control of the reference or version of vagrant-spec to be used
from the dev environment where it is necessary to test with older
versions of the plugin which may depend on different versions of
dependencies compared to vagrant-spec.
In this case the latest vagrant-spec has rolled forward the rspec core
version to 3.10, which works with the latest vagrant-libvirt. However
previous versions of vagrant-libvirt require 3.5, which was the previous
minor version pinned.
Adding the option of VAGRANT_SPEC_VERSION that can be set as an
environment variable should help control this explicitly when needed in
the future the same as how VAGRANT_VERSION is handled.