Regression unit test for frozen string literal fix #1393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a unit test for the prepare nfs settings action to act as a regression test for the recent fix to avoiding modifying a frozen string literal. As part of this fix how the communicator is returned via a call to a machine for testing purposes and remove an obsolete expect from the wait till up tests as the code that would result in the communicator being called has been removed.
electrofelix
deleted the
add-nfs-prepare-frozen-strings-regression-unit-test
branch
mmguero
pushed a commit
to mmguero-dev/vagrant-libvirt
that referenced
this pull request
Nov 9, 2021
) Add a unit test for the prepare nfs settings action to act as a regression test for the recent fix to avoiding modifying a frozen string literal. As part of this fix how the communicator is returned via a call to a machine for testing purposes and remove an obsolete expect from the wait till up tests as the code that would result in the communicator being called has been removed. Ensure that nfsd is not required to run the tests by mocking out the host capability check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a unit test for the prepare nfs settings action to act as a
regression test for the recent fix to avoiding modifying a frozen string
literal.
As part of this fix how the communicator is returned via a call to a
machine for testing purposes and remove an obsolete expect from the
wait till up tests as the code that would result in the communicator
being called has been removed.