Ensure sessions trigger a listing of the network devices #1409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
List network devices to trigger a side effect to ensure the qemu-bridge-helper will run correctly for users of the modular daemons. It is likely that this should be done for sessions to support resolving the correct virtual bridge device anyway, however that is more involved and maybe superseded by not needing a network interface should qemu agent be able to act as a communicator. Or to perform port forwarding using qemuargs to allow SSH access directly in. Fixes: #1258
mmguero
pushed a commit
to mmguero-dev/vagrant-libvirt
that referenced
this pull request
Nov 30, 2021
…virt#1409) List network devices to trigger a side effect to ensure the qemu-bridge-helper will run correctly for users of the modular daemons. It is likely that this should be done for sessions to support resolving the correct virtual bridge device anyway, however that is more involved and maybe superseded by not needing a network interface should qemu agent be able to act as a communicator. Or to perform port forwarding using qemuargs to allow SSH access directly in. Fixes: vagrant-libvirt#1258
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List network devices to trigger a side effect to ensure the
qemu-bridge-helper will run correctly for users of the modular daemons.
It is likely that this should be done for sessions to support resolving
the correct virtual bridge device anyway, however that is more involved
and maybe superseded by not needing a network interface should qemu
agent be able to act as a communicator. Or to perform port forwarding
using qemuargs to allow SSH access directly in.
Fixes: #1258