Use instance doubles for driver where possible #1491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to instance doubles for driver where possible and reduce usage of allow_any_instance_of. Additionally replace some incorrect allows with expects to validate calls are not made.
electrofelix
deleted the
correct-driver-connection-double-and-undefine-check
branch
mmguero
pushed a commit
to mmguero-dev/vagrant-libvirt
that referenced
this pull request
May 9, 2022
Switch to instance doubles for driver where possible and reduce usage of allow_any_instance_of. Additionally replace some incorrect allows with expects to validate calls are not made.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to instance doubles for driver where possible and reduce usage of
allow_any_instance_of.
Additionally replace some incorrect allows with expects to validate
calls are not made.