Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .golangci.yaml #4

Closed
vaguecoder opened this issue Dec 31, 2022 · 3 comments · Fixed by #34
Closed

Add .golangci.yaml #4

vaguecoder opened this issue Dec 31, 2022 · 3 comments · Fixed by #34
Assignees
@tanryberdi
Labels
code-quality Improve code quality dev-exp Developer experience golang Golang related code changes (required/expected) good first issue Good for newcomers todo Has TODOs to create indicidual issues from

Comments

@vaguecoder
Copy link
Owner

Add golangci-lint to the project and add the target to Makefile
@vaguecoder vaguecoder changed the title Add .golangci.yaml Add .golangci.yml Dec 31, 2022
@vaguecoder vaguecoder changed the title Add .golangci.yml Add .golangci.yaml Dec 31, 2022
@vaguecoder vaguecoder added good first issue Good for newcomers golang Golang related code changes (required/expected) labels Dec 31, 2022
@tanryberdi
Copy link

@assign

@vaguecoder
Copy link
Owner Author

@tanryberdi To explain a bit on this, we need to configure .golangci.yaml to use some default + commonly used linters from golangci-lint. Try not to exclude any path unless necessary (and for specific linters).

tanryberdi added a commit to tanryberdi/gorilla-mux that referenced this issue Jan 9, 2023
@tanryberdi
Chore: Add .golangci.yaml file
f18bf34 
- added .golangci.yaml file
Signed-off-by: Tanryberdi <tanryberdi@gmail.com>

See vaguecoder#4
@tanryberdi tanryberdi mentioned this issue Jan 9, 2023
Merged
@vaguecoder vaguecoder added dev-exp Developer experience code-quality Improve code quality todo Has TODOs to create indicidual issues from labels Jan 10, 2023
tanryberdi added a commit to tanryberdi/gorilla-mux that referenced this issue Jan 10, 2023
@tanryberdi
Chore: Add .golangci.yaml file
0ea0af5 
- added .golangci.yaml file
Signed-off-by: Tanryberdi <tanryberdi@gmail.com>

See vaguecoder#4
@vaguecoder vaguecoder linked a pull request Jan 10, 2023 that will close this issue
Chore: Add .golangci.yaml file #34
Merged
tanryberdi added a commit to tanryberdi/gorilla-mux that referenced this issue Jan 11, 2023
@tanryberdi
Chore: Add .golangci.yaml file
e5d9dec 
- added .golangci.yaml file
Signed-off-by: Tanryberdi <tanryberdi@gmail.com>

See vaguecoder#4
vaguecoder pushed a commit that referenced this issue Jan 11, 2023
@tanryberdi @vaguecoder
Chore: Add .golangci.yaml file
9728d69 
- added .golangci.yaml file
Signed-off-by: Tanryberdi <tanryberdi@gmail.com>

See #4
@vaguecoder
Copy link
Owner Author

Thanks @tanryberdi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tanryberdi tanryberdi

Labels
code-quality Improve code quality dev-exp Developer experience golang Golang related code changes (required/expected) good first issue Good for newcomers todo Has TODOs to create indicidual issues from
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Chore: Add .golangci.yaml file tanryberdi/gorilla-mux
2 participants
@tanryberdi @vaguecoder