Fix incorrect default value of points validity.

A default constructed point is an invalid one.
vahancho · Jun 13, 2019 · 1842806 · 1842806
1 parent f964bf6
commit 1842806
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/point.cpp b/src/point.cpp
@@ -31,7 +31,7 @@ Point::Point()
   :
     m_latitude(0.0),
     m_longitude(0.0),
-    m_isValid(true)
+    m_isValid(false)
 {}
 
 Point::Point(const Latitude &latitude, const Longitude &longitude)

diff --git a/test/test.cpp b/test/test.cpp
@@ -113,6 +113,18 @@ static void reportTime(std::chrono::time_point<std::chrono::high_resolution_cloc
 
 int main()
 {
+  {
+    Point p{};
+    p.isValid() ? ++s_failed : ++s_passed;
+    verifyDouble(0.0, p.latitude().degrees(), LOCATION);
+    verifyDouble(0.0, p.longitude().degrees(), LOCATION);
+  }
+  {
+    spherical::Point p{};
+    p.isValid() ? ++s_failed : ++s_passed;
+    verifyDouble(0.0, p.latitude().degrees(), LOCATION);
+    verifyDouble(0.0, p.longitude().degrees(), LOCATION);
+  }
   {
     spherical::Point p1{ 52.205, 0.119 };
     spherical::Point p2{ 48.857, 2.351 };