Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add chrome.action mv3 #280

Merged
merged 1 commit into from
Mar 27, 2022
Merged

feat: add chrome.action mv3 #280

merged 1 commit into from
Mar 27, 2022

Conversation

Yash-Singh1
Copy link
Contributor

Adds the MV3 chrome.action chrome extension API and adds group and ungroup to chrome.tabs.

@fikstoday
Copy link

Now we await merge completion.
What would be PR turn-around??

@vaibhavhrt vaibhavhrt merged commit d0aea16 into vaibhavhrt:master Mar 27, 2022
@vaibhavhrt
Copy link
Owner

@Yash-Singh1 thanks for the PR. Sorry about the delay, I was quite busy last few days. You can open PRs for adding rest of the APIs too, I will try and merge them sooner now. I will also open PRs to add some of the new APIs.

@vaibhavhrt
Copy link
Owner

@Yash-Singh1 also if you have any suggestions for structuring the code better please let me know. As you must have already noticed that adding any new auto-completion is quite a lot of work and needs changes in various files.
I am trying to find ways so that we can add completion providers in a more robust ways instead of hard coding everything. Then we may also we able to write a script to scrape all APIs docs from the chrome website and create a JSON file from it, so that updating the extension will require minimal work.

@vaibhavhrt
Copy link
Owner

For now the PR is merged, but the new APIs you added won't be available on the extension we have on visual studio store. I will make a release later, once we have added all the new APIs.

@Yash-Singh1
Copy link
Contributor Author

@Yash-Singh1 also if you have any suggestions for structuring the code better please let me know. As you must have already noticed that adding any new auto-completion is quite a lot of work and needs changes in various files.

I am trying to find ways so that we can add completion providers in a more robust ways instead of hard coding everything. Then we may also we able to write a script to scrape all APIs docs from the chrome website and create a JSON file from it, so that updating the extension will require minimal work.

Yeah, I was thinking of that too, maybe like a GitHub action cron job that updates the Json often.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants