Skip to content
This repository has been archived by the owner on Nov 8, 2023. It is now read-only.

Implement insecure HTTP client #31

Merged
merged 5 commits into from
Nov 7, 2023
Merged

Implement insecure HTTP client #31

merged 5 commits into from
Nov 7, 2023

Conversation

vaibhavjainwiz
Copy link
Owner

No description provided.

@vaibhavjainwiz vaibhavjainwiz changed the title Implement HTTP client Implement insecure HTTP client Nov 6, 2023
z103cb
z103cb reviewed Nov 6, 2023
View reviewed changes
Copy link
Contributor

@z103cb z103cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, step in the right direction

dtrifiro
dtrifiro reviewed Nov 6, 2023
View reviewed changes
tests/conftest.py Outdated Show resolved Hide resolved
z103cb
z103cb approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@z103cb z103cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vaibhavjainwiz vaibhavjainwiz linked an issue Nov 6, 2023 that may be closed by this pull request
Set up text fixture for http server #22
Closed
@vaibhavjainwiz vaibhavjainwiz mentioned this pull request Nov 6, 2023
Closed
@vaibhavjainwiz vaibhavjainwiz linked an issue Nov 6, 2023 that may be closed by this pull request
[STORY] Enable Caikit Python API library opendatahub-io/caikit#15
Closed
@vaibhavjainwiz vaibhavjainwiz merged commit 37ca131 into main Nov 7, 2023
4 of 18 checks passed
@dtrifiro dtrifiro deleted the http_client branch November 7, 2023 15:17
@dtrifiro dtrifiro mentioned this pull request Nov 7, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dtrifiro dtrifiro dtrifiro left review comments

@z103cb z103cb z103cb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set up text fixture for http server [STORY] Enable Caikit Python API library
3 participants
@vaibhavjainwiz @dtrifiro @z103cb