Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full gitignore, travis ci setup file, readme badge and codacy edits #6

Merged
merged 8 commits into from
Jul 1, 2019
Merged

Full gitignore, travis ci setup file, readme badge and codacy edits #6

merged 8 commits into from
Jul 1, 2019

Conversation

SamSamhuns
Copy link
Contributor

No description provided.

@4shadoww
Copy link
Contributor

Could you add to the key bindings section new key bindings: key "u" for volume up and "d" for volume down? I forgot to do that update to the read me when I made #5 pull request.

@SamSamhuns
Copy link
Contributor Author

Could you add to the key bindings section new key bindings: key "u" for volume up and "d" for volume down? I forgot to do that update to the read me when I made #5 pull request.

Done.

@ceoro9
Copy link

ceoro9 commented Jun 30, 2019

@SamSamhuns also in readme under installation section, version of packages are out-dated. Can you please make them correspond the requirements.txt. But to be fair I would rather completely remove such installation option, idk.

@SamSamhuns
Copy link
Contributor Author

@SamSamhuns also in readme under installation section, version of packages are out-dated. Can you please make them correspond the requirements.txt. But to be fair I would rather completely remove such installation option, idk.

Yes, I believe it is better to remove the version numbers in the req. These packages should be backward compatible in updated versions.

@vaibkumr vaibkumr merged commit d26af8a into vaibkumr:master Jul 1, 2019
@vaibkumr
Copy link
Owner

vaibkumr commented Jul 1, 2019

Thank you everyone for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants