Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mpv thread not terminating when quitting from start screen + error handling to play_at_index() #7

Merged
merged 3 commits into from
Jul 1, 2019

Conversation

4shadoww
Copy link
Contributor

@4shadoww 4shadoww commented Jul 1, 2019

For some reason mpv thread won't quit after quitting from start screen. After researching I didn't find better fix for this than simply creating mpv object after start screen.

@4shadoww 4shadoww changed the title fix mpv thread not terminating when quitting from start screen fix mpv thread not terminating when quitting from start screen + error handling to play_at_index() Jul 1, 2019
@4shadoww
Copy link
Contributor Author

4shadoww commented Jul 1, 2019

Pushed another commit which adds error handling to YoutubePlayer.play_at_index()

@vaibkumr
Copy link
Owner

vaibkumr commented Jul 1, 2019

I just happen to add an exception at play_at_index(). For now, I skipped the current song and play next by printing an ugly message on the screen which breaks the UI (will replace it with urwid floating box soon)
I am not sure why main thread does not exit but your fix seems amazing. Can you please make the pull request for it again?
EDIT - I fixed the conflict, we were doing the same thing. It now quits on the start screen, thanks to you!

@vaibkumr vaibkumr merged commit b841e5f into vaibkumr:master Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants