Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Composer v2 #59

Closed
allanpaiste opened this issue May 23, 2020 · 11 comments
Closed

Support for Composer v2 #59

allanpaiste opened this issue May 23, 2020 · 11 comments

Comments

@allanpaiste
Copy link
Contributor

New major version for Composer is on the horizon and will introduce new plugin API:

https://php.watch/articles/composer-2#plugin-api-2

Describe the solution you'd like
Make sure that this plugin complies to said changes (probably requires new MAJOR release).

@hostep
Copy link
Contributor

hostep commented Sep 27, 2020

According to composer/composer#8726 (comment), this is the top 26th used composer plugin not yet supporting composer 2. Would be nice if this can get resolved some day 🙂. The first release candidate for composer 2 was released about 2 weeks ago btw: https://github.com/composer/composer/releases/tag/2.0.0-RC1

Thanks for the great work btw! Been using this as a replacement of https://github.com/cweagans/composer-patches for about 4 months now, very happy with the switch so far!

@hostep
Copy link
Contributor

hostep commented Oct 26, 2020

Hi @allanpaiste

Now that composer v2 is released, are there plans to start supporting it in the near future?

Thanks a lot!

@deoomen
Copy link

deoomen commented Dec 17, 2020

Any news? Support for composer 2 would be great.

@hostep
Copy link
Contributor

hostep commented Jan 4, 2021

Hi @BarnyShergold, sorry to include you but we briefly talked on Slack about this.
Do you have an update around this, any chance this will get worked on in the near future?

Thanks!

@BarnyShergold
Copy link

@hostep - I checked today and whilst this repo IS still under maintenance and development and WILL be updated to support Composer 2 (I've seen the ticket list!) there is no timeline when this will happen. Sorry I can't be the bearer of better news

@hostep
Copy link
Contributor

hostep commented Jan 14, 2021

I'd like to emphasise the urgency here. We are using this module for many Magento 2 shops. Magento 2.4.2 which is going to be released in 3 weeks will support composer version 2 and I'm not sure if their dependencies will be able to keep working on composer version 1. So it could be that we won't be able to use Magento 2.4.2 in combination with this module if composer v2 support isn't added here quickly.

@hostep
Copy link
Contributor

hostep commented Jan 14, 2021

This module was once forked from https://github.com/cweagans/composer-patches, so maybe their changes to make it compatible with composer v2 are enough to make this module work as well, but this module is more complex so I'm not sure.

Unfortunately I haven't got time myself to figure this out, maybe within a couple of weeks, but not in the short run.

@hostep
Copy link
Contributor

hostep commented Jan 28, 2021

I attempted bringing in support for composer v2 but I think I will give up because it's too hard for somebody who's not familiar with this codebase or with composer's internals. Hoping that the changes I did manage to make turn out to be useful for somebody else who likes to attempt this: #63

@allanpaiste
Copy link
Contributor Author

allanpaiste commented Feb 20, 2021

Resolved in:

Kudos to @hostep for spearheading this whole thing :)

@allanpaiste allanpaiste changed the title Support for Composer 2 Support for Composer v2 Feb 20, 2021
@andriyun
Copy link

Thank you very much

@hostep
Copy link
Contributor

hostep commented Feb 22, 2021

Thank you very much @allanpaiste!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants