workflow improvements #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... Destructors
- fix documentHighlight: - only highlight references in current document - don't highlight lambdas - handle references across build targets in the same project
Prince781
force-pushed
the
wip/workflow-improvements
branch
8 times, most recently
from
ad6ff1c
to
657815c
Compare
- handle cross-target references - improve detection of implementing types using Vala.TypeSymbol.is_a() - don't show symbols more than once if they are part of multiple code nodes with the same source reference - don't show references/implementations from the same file more than once, if the file is used by multiple compilations - show references/implementations in system VAPIs
This includes symbols that are implemented.
- completing member accesses within tuples/method arguments - signature help when method arguments are literals - parsing other types of literals (int, real, bool) - extract array element accesses
Prince781
force-pushed
the
wip/workflow-improvements
branch
from
657815c
to
68241b4
Compare
- moved symbol display and other related items to Vls.CodeHelp
This allows us to setup the document outline/tree first, and then have the ranges computed correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can read the commit messages to get a better understanding of this. Basically, the major features are:
textDocument/referencesandtextDocument/implementationfor references to symbols across build targets#!usually) in Vala scripts (closes Argument analysis for interpeter line in Vala scripts #113)