feat: Allow ${workspaceFolder} in vala.languageServerPath configuration
#25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prince781
reviewed
May 13, 2023
|
Is it possible to release this patch? |
Prince781
requested changes
Oct 15, 2023
caspermeijn
force-pushed
the
workspaceFolder
branch
from
aeb6dd2
to
7333f74
Compare
Prince781
force-pushed
the
workspaceFolder
branch
from
b66b1b5
to
08d881e
Compare
Prince781
previously approved these changes
Oct 28, 2023
…ration The predefined VSCode variables [1] are not automatically substituted for configuration options. The Vala extension must do the substitution to allow the Vala language server to be relative to the workspace folder. This patch is a simplified version of the substitution in the Rust extension [2]. [1]: https://code.visualstudio.com/docs/editor/variables-reference#_predefined-variables [2]: https://github.com/rust-lang/rust-analyzer/blob/884dd8c966e29d48bd9f8e5f22440cd238aa7cf1/editors/code/src/config.ts#L399 Signed-off-by: Casper Meijn <casper@meijn.net> Signed-off-by: Princeton Ferro <princetonferro@gmail.com>
Prince781
force-pushed
the
workspaceFolder
branch
from
08d881e
to
798ca3a
Compare
|
Thanks for the release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The predefined VSCode variables 1 are not automatically substituted for configuration options. The Vala extension must do the substitution to allow the Vala language server to be relative to the workspace folder.
This patch is a simplified version of the substitution in the Rust extension 2.