Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1 adding build action #14

Merged
merged 22 commits into from
Jul 8, 2022
Merged

#1 adding build action #14

merged 22 commits into from
Jul 8, 2022

Conversation

pwnyprod
Copy link
Collaborator

@pwnyprod pwnyprod commented Jul 8, 2022

Changes

Breaking changes

  • n/a

New / changed / removed

  • added build github action workflow

Improvements

  • n/a
Code Review

Code Review

What's part of a code review?

Readability & Maintainability

  • Code is not more complex than needed
  • Clear names are used (good naming practices)
  • Test coverage is sufficient and tests are well designed
  • Code has proper error handling

Documentation

  • Code is properly documented

Security & Performance

  • No obvious security flaws
  • No notable performance decrease

pwnyprod and others added 22 commits July 8, 2022 13:30
@pwnyprod
#1 adding build action
dacc989
@pwnyprod
Merge remote-tracking branch 'origin/main' into #1-CI/CD_Integration
7189c92
Merge branch 'main' into #1-CI/CD_Integration
fffbabb
@pwnyprod
Merge remote-tracking branch 'origin/#1-CI/CD_Integration' into #1-CI…
4544f1e 
…/CD_Integration
@pwnyprod
#1 adding unittest step and fixup ProjectMock
19a2ec8
@pwnyprod
#1 adding job dependency
0dc5be0
@pwnyprod
#1 adding job dependency
c88fc12
@pwnyprod
#1 adding job dependency
4d9b8ea
@pwnyprod
#1 merging gh action kits together
0ebfda0
generate cache file
2763cfa
1.6
cdd8e68
@pwnyprod
#1 adding nessesary deps in test step
aea5475
@pwnyprod
Merge remote-tracking branch 'origin/main' into #1-CI/CD_Integration
6e24653 
# Conflicts:
#	build.gradle.kts
1.6
eba9c44
Merge remote-tracking branch 'origin/#1-CI/CD_Integration' into #1-CI…
f2679a6 
…/CD_Integration
@pwnyprod
#1 fixed tests and some linting
5601b70
@pwnyprod
#1 installing ci tree, my dog stepped on a bee
561f6ea
@pwnyprod
#1 installing ci tree, my dog stepped on a bee
853a750
@pwnyprod
#1 installing ci tree, my dog stepped on a bee
8a152a2
@pwnyprod
#1 installing ci tree, my dog stepped on a bee
28659d3
@pwnyprod
#1 installing ci tree, my dog stepped on a bee
63ef308
@pwnyprod
#1 installing ci tree, my dog stepped on a bee
b81133a
@pwnyprod pwnyprod merged commit abfc897 into main Jul 8, 2022
@pwnyprod pwnyprod added this to In progress in Spryker Hackathon 2022 via automation Jul 8, 2022
@pwnyprod pwnyprod linked an issue Jul 8, 2022 that may be closed by this pull request
CI/CD Integration #1
Closed
6 tasks
@pwnyprod pwnyprod moved this from In progress to Done in Spryker Hackathon 2022 Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Spryker Hackathon 2022
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI/CD Integration
1 participant
@pwnyprod