Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added missing IDE Versions and fixing qodana warnings #20

Merged
merged 1 commit into from
Jul 14, 2022
Merged

added missing IDE Versions and fixing qodana warnings #20

merged 1 commit into from
Jul 14, 2022

Conversation

pwnyprod
Copy link
Collaborator

@pwnyprod pwnyprod commented Jul 11, 2022 •
edited
Loading

Changes

Breaking changes

  • n/a

New / changed / removed

  • changing some sniffs in files
  • removed qodana from CI
  • added missing IDE Versions to list

Improvements

  • n/a
Code Review

Code Review

What's part of a code review?

Readability & Maintainability

  • Code is not more complex than needed
  • Clear names are used (good naming practices)
  • Test coverage is sufficient and tests are well designed
  • Code has proper error handling

Documentation

  • Code is properly documented

Security & Performance

  • No obvious security flaws
  • No notable performance decrease

@pwnyprod pwnyprod added the enhancement New feature or request label Jul 11, 2022
@pwnyprod pwnyprod self-assigned this Jul 12, 2022
@pwnyprod pwnyprod added CI/CD all deployment and github action changes java for java file changes labels Jul 12, 2022
@pwnyprod pwnyprod linked an issue Jul 12, 2022 that may be closed by this pull request
Verify the pluginGroup, plugin ID and sources package #4
Closed
4 tasks
@pwnyprod pwnyprod merged commit f1cc272 into main Jul 14, 2022
@pwnyprod pwnyprod deleted the 4-verify-the-plugingroup-plugin-id-and-sources-package branch July 14, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pwnyprod pwnyprod

Labels
CI/CD all deployment and github action changes enhancement New feature or request java for java file changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Verify the pluginGroup, plugin ID and sources package
1 participant
@pwnyprod