Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed Index should not be blue/green switched #54

Closed
rliebi opened this issue Dec 21, 2023 · 1 comment
Closed

Failed Index should not be blue/green switched #54

rliebi opened this issue Dec 21, 2023 · 1 comment
Assignees
@limenet
Labels
bug Something isn't working
Milestone
v4.0.0

Comments

@rliebi
Copy link
Contributor

rliebi commented Dec 21, 2023

A failed index should not activate blue/green switch

image
@rliebi rliebi added the bug Something isn't working label Dec 21, 2023
@limenet
Copy link
Member

limenet commented Jan 4, 2024

As discussed:

  • We move the try-catch throwing a IndexingFailedException inside the inner-most foreach to catch document errors
  • We introduce a new flag to toggle between silent failures (i.e. skip erroneous documents) and exiting the indexing process
  • We consider firing event(s) when exceptions are caught to enable e.g. error reporting to 3rd party services

@limenet limenet added this to the v4.0.0 milestone Jan 4, 2024
limenet added a commit that referenced this issue Jan 22, 2024
@limenet
add error handling for failing documents during indexing
fb0b41c 
Added exception handling for failing documents during indexing in the `PopulateIndex` command. When a document fails to be indexed, an error message is displayed, and depending on the value of `should_skip_failing_documents` configuration option, indexing either continues or is aborted. If `should_skip_failing_documents` is set to `false`, a `DocumentFailedException` is thrown. Also added a new `DocumentFailedException` class to handle this type of exception.

Closes #54
limenet added a commit that referenced this issue Jan 22, 2024
@limenet
add error handling for failing documents during indexing
948fe70 
Added exception handling for failing documents during indexing in the `PopulateIndex` command. When a document fails to be indexed, an error message is displayed, and depending on the value of `should_skip_failing_documents` configuration option, indexing either continues or is aborted. If `should_skip_failing_documents` is set to `false`, a `DocumentFailedException` is thrown. Also added a new `DocumentFailedException` class to handle this type of exception.

Closes #54
limenet added a commit that referenced this issue Jan 22, 2024
@limenet
add error handling for failing documents during indexing
b423c61 
Added exception handling for failing documents during indexing in the `PopulateIndex` command. When a document fails to be indexed, an error message is displayed, and depending on the value of `should_skip_failing_documents` configuration option, indexing either continues or is aborted. If `should_skip_failing_documents` is set to `false`, a `DocumentFailedException` is thrown. Also added a new `DocumentFailedException` class to handle this type of exception.

Closes #54
limenet added a commit that referenced this issue Jan 22, 2024
@limenet
add error handling for failing documents during indexing
d2c7b91 
Added exception handling for failing documents during indexing in the `PopulateIndex` command. When a document fails to be indexed, an error message is displayed, and depending on the value of `should_skip_failing_documents` configuration option, indexing either continues or is aborted. If `should_skip_failing_documents` is set to `false`, a `DocumentFailedException` is thrown. Also added a new `DocumentFailedException` class to handle this type of exception.

Closes #54
limenet added a commit that referenced this issue Jan 22, 2024
@limenet
add error handling for failing documents during indexing
7765e9c 
Added exception handling for failing documents during indexing in the `PopulateIndex` command. When a document fails to be indexed, an error message is displayed, and depending on the value of `should_skip_failing_documents` configuration option, indexing either continues or is aborted. If `should_skip_failing_documents` is set to `false`, a `DocumentFailedException` is thrown. Also added a new `DocumentFailedException` class to handle this type of exception.

Closes #54
@limenet limenet mentioned this issue Jan 22, 2024
Merged
limenet added a commit that referenced this issue Jan 24, 2024
@limenet
add error handling for failing documents during indexing
71fbebb 
Added exception handling for failing documents during indexing in the `PopulateIndex` command. When a document fails to be indexed, an error message is displayed, and depending on the value of `should_skip_failing_documents` configuration option, indexing either continues or is aborted. If `should_skip_failing_documents` is set to `false`, a `DocumentFailedException` is thrown. Also added a new `DocumentFailedException` class to handle this type of exception.

Closes #54
limenet added a commit that referenced this issue Jan 25, 2024
@limenet
add error handling for failing documents during indexing
72cecec 
Added exception handling for failing documents during indexing in the `PopulateIndex` command. When a document fails to be indexed, an error message is displayed, and depending on the value of `should_skip_failing_documents` configuration option, indexing either continues or is aborted. If `should_skip_failing_documents` is set to `false`, a `DocumentFailedException` is thrown. Also added a new `DocumentFailedException` class to handle this type of exception.

Closes #54
limenet added a commit that referenced this issue Feb 14, 2024
@limenet
add error handling for failing documents during indexing
7314d12 
Added exception handling for failing documents during indexing in the `PopulateIndex` command. When a document fails to be indexed, an error message is displayed, and depending on the value of `should_skip_failing_documents` configuration option, indexing either continues or is aborted. If `should_skip_failing_documents` is set to `false`, a `DocumentFailedException` is thrown. Also added a new `DocumentFailedException` class to handle this type of exception.

Closes #54
limenet added a commit that referenced this issue Feb 20, 2024
@limenet
add error handling for failing documents during indexing
1650a55 
Added exception handling for failing documents during indexing in the `PopulateIndex` command. When a document fails to be indexed, an error message is displayed, and depending on the value of `should_skip_failing_documents` configuration option, indexing either continues or is aborted. If `should_skip_failing_documents` is set to `false`, a `DocumentFailedException` is thrown. Also added a new `DocumentFailedException` class to handle this type of exception.

Closes #54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@limenet limenet

Labels
bug Something isn't working
Projects
None yet
Milestone
v4.0.0
Development

No branches or pull requests
2 participants
@limenet @rliebi