Release/5.2.0 #109
Merged
Release/5.2.0 #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mob8607
approved these changes
Aug 25, 2020
CHANGES.md
Outdated
| ### v 6.0.0 (2020-08-20) | ||
| - (Breaking) Refactors c-modal header component to slot. | ||
| - (Feature) New outside click directive. | ||
| - (Feature) New body scroll plugin. |
There was a problem hiding this comment.
Is the new body scroll plugin already included? It's not in here 😱
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Replaces body scroll helper, adds outside click directive and refactors modal header to slot.
Note: We can also merge this with version 5.1.0. I just don't wanted to block that release with this new changes.
Ticket
No ticket
Browser testing
Checklist
Review/Test checklist