Do not isolate distinct
to avoid missing renames
#168
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #165 by removing isolate from
distinct
calls.Recall that queries in the form:
Cause Selda + the psql backend to fail. For a complete program see #165 and a throw-away psql such as
docker run -p 5432:5432 --rm -e POSTGRES_PASSWORD=password -d postgres
.This query now succeeds along with
make test
and themake pgtest
target. That said, I don't claim to have shoved the whole selda design into my head so viewing the PR with some suspicion is warranted.