Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EditContainerClass does not seem to work with EPiBootstrapArea #23

Closed
Codecamv opened this issue Oct 31, 2016 · 14 comments
Closed

EditContainerClass does not seem to work with EPiBootstrapArea #23

Codecamv opened this issue Oct 31, 2016 · 14 comments
Assignees
Labels

Comments

@Codecamv
Copy link

We're having problems with specifying a class which should only be displayed on the container if in edit mode.

By default EPiServer offers the property EditContainerClass for this purpose:
`


@Html.PropertyFor(x => x.MainContentArea, new { EditContainerClass ="editor-overflow-hidden" })

`

However, it seems to me that this property is swallowed by EPiBootstrapArea. Workaround is to have an if statement in the view which checks if in edit mode, if so use CssClass. CssClass seems to flow through EPiBootstrapArea correctly.

@valdisiljuconoks
Copy link
Owner

Looks like a bug. Are you on EPi v10?

@Codecamv
Copy link
Author

No, we're currently on the last version of the 9 series of EPi. Does EPiBootstapArea support EPi v10 now?

Thanks for your fast reply on this issue.

@valdisiljuconoks
Copy link
Owner

I'm pretty close to release it. Will take a look altogether.

@valdisiljuconoks
Copy link
Owner

valdisiljuconoks commented Nov 1, 2016

I'm not quite sure that EPiServer renders things correctly. Here is repro:

  1. Create clean AlloyTech (with no plugin installed). EPiServer version 10.0.1
  2. Modify start page template:
@Html.PropertyFor(x => x.CurrentPage.MainContentArea, new { CssClass = "css-class", EditContainerClass = "edit-container-class" })
  1. inspect result markup for edit mode:
<div class="css-class" data-epi-property-name="MainContentArea" data-epi-use-mvc="True" data-epi-property-rendersettings="{&quot;cssClass&quot;:&quot;css-class&quot;,&quot;editContainerClass&quot;:&quot;edit-container-class&quot;}" style="min-height: 56px;">....

I know that it should be working. What I'm missing? I want to understand where this is working in clean Alloy before jumping to fixing the bug.

@valdisiljuconoks
Copy link
Owner

The same issue is in 9x versions

@Codecamv
Copy link
Author

Codecamv commented Nov 1, 2016

Maybe I got it wrong and it's an episerver bug. I'll check it out in my project now

@Codecamv
Copy link
Author

Codecamv commented Nov 1, 2016

Seems like an EPi bug, can reproduce bug in CMS 9.12.2 . I'll create an EPi support ticket.

@valdisiljuconoks
Copy link
Owner

Which version you were using that supported this feature?

@Codecamv
Copy link
Author

Codecamv commented Nov 2, 2016

@Codecamv
Copy link
Author

Codecamv commented Nov 2, 2016

From epi support: "I have reported a bug on this issue in our tracking system with id CMS-5125. You should be able to track the status of the bug through our buglist on Episerver world once it goes through triage, accepted as bug and become active."

@valdisiljuconoks
Copy link
Owner

Ok, let's wait for triage.

@valdisiljuconoks
Copy link
Owner

Any feedback on this?

@Codecamv
Copy link
Author

No, I can't seem to find CMS-5125 in the official buglist. I'll contact
support and ask for an update.

I'll give u feedback when I have it.

On Fri, Nov 18, 2016 at 11:03 PM, Wałdis Iljuczonok <
notifications@github.com> wrote:

Any feedback on this?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#23 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAyQx2iQcVbLhFZww4zPUp-ObgDFHl22ks5q_iCugaJpZM4KlCbM
.

@Codecamv
Copy link
Author

I got the following answer from EPi support:

The bug CMS-5125 has been closed as "Not a problem" as EditContainerClass was renamed to CssClass when rendering of content areas was rewritten as part of CMS 7.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants