12-hour clock modes #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perfect! Thank you very much. |
|
One issue, I forgot to correct the usage info in the |
|
@Kyllingene no problem, already fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements both of the 12-hour modes I described here, under the flags
-u(for the date-line mode) and-U(for the block-style mode). You can have both enabled, though I don't see why you would want to.I also ran
cargo clippyand implemented some of the less intrusive changes (+=instead of_ = _ + ..., unnecessary allocations, etc.). If you wish, I can revert that commit and separate it out into a new PR.