Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build warning - patch available #183

Closed
FabioPedretti opened this issue Jun 11, 2013 · 2 comments
Closed

Build warning - patch available #183

FabioPedretti opened this issue Jun 11, 2013 · 2 comments

Comments

@FabioPedretti
Copy link

0 A.D. embedded mongoose and was getting this warnigs:

../../../source/third_party/mongoose/mongoose.cpp: In function �void MD5Final(unsigned char*, MD5_CTX*)�:
../../../source/third_party/mongoose/mongoose.cpp:1999:28: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
../../../source/third_party/mongoose/mongoose.cpp:2000:28: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]

Fixed downstream with:
http://trac.wildfiregames.com/changeset/13469/ps/trunk/source/third_party/mongoose/mongoose.cpp
@cpq
Copy link
Member

cpq commented Jun 11, 2013

Thanks. I am wondering is this fix correct on both little and big endian platforms?

@cpq
Copy link
Member

cpq commented Aug 14, 2013

Closing this, as I am not sure the fix is endian-friendly.

@cpq cpq closed this as completed Aug 14, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cpq @FabioPedretti