Skip to content

Commit

Permalink
cryptenroll: fix a memory leak
Browse files Browse the repository at this point in the history
$ dd if=/dev/zero of=luks.img bs=1M count=64
$ echo 1231dfsd234d | cryptsetup luksFormat luks.img
$ build-san/systemd-cryptenroll luks.img
SLOT TYPE
   0 password

=================================================================
==640364==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 64 byte(s) in 1 object(s) allocated from:
    #0 0x7f43ffeb95b5 in __interceptor_realloc.part.0 (/lib64/libasan.so.8+0xb95b5)
    #1 0x7f43ff0a4f2f in greedy_realloc ../src/basic/alloc-util.c:70
    #2 0x404d9f in list_enrolled ../src/cryptenroll/cryptenroll-list.c:30
    #3 0x40f149 in run ../src/cryptenroll/cryptenroll.c:673
    #4 0x40f149 in main ../src/cryptenroll/cryptenroll.c:692
    #5 0x7f43fd64a50f in __libc_start_call_main (/lib64/libc.so.6+0x2750f)

SUMMARY: AddressSanitizer: 64 byte(s) leaked in 1 allocation(s).
Aborted (core dumped)

Reported in systemd#27007.
  • Loading branch information
mrc0mmand authored and yuwata committed Mar 28, 2023
1 parent 485d32d commit 30dbadf
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions src/cryptenroll/cryptenroll-list.c
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,13 @@
#include "format-table.h"
#include "parse-util.h"

int list_enrolled(struct crypt_device *cd) {
struct keyslot_metadata {
int slot;
const char *type;
};

struct keyslot_metadata {
int slot;
const char *type;
} *keyslot_metadata = NULL;
int list_enrolled(struct crypt_device *cd) {
_cleanup_free_ struct keyslot_metadata *keyslot_metadata = NULL;
_cleanup_(table_unrefp) Table *t = NULL;
size_t n_keyslot_metadata = 0;
int slot_max, r;
Expand Down

0 comments on commit 30dbadf

Please sign in to comment.