Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing privacy API #15

Open
dmitriim opened this issue Apr 16, 2020 · 4 comments
Open

Implementing privacy API #15

dmitriim opened this issue Apr 16, 2020 · 4 comments

Comments

@dmitriim
Copy link

Moodle plugins need to implement privacy API https://docs.moodle.org/dev/Privacy_API otherwise unit tests will fail.

dmitriim added a commit to catalyst/moodle-webhooks that referenced this issue Apr 16, 2020
@valentineus
Copy link
Owner

Thanks! It's a valuable issue. I didn't know about that.

I have got a little mess in the repository.
Can you set PR to v3.0.0-stable brach?

@dmitriim
Copy link
Author

dmitriim commented Apr 21, 2020

Hi @valentineus! Not really relevant, to this issue, but is there any reason why v3.0.0-stable requires moodle 3.8 and not 3.7 as minimum version? https://github.com/valentineus/moodle-webhooks/blob/v3.0.0-stable/version.php#L30
As far as I can see it doesn't use anything specific to 3.8. Will it possible to set 3.7 as a minimum required version?
In our particular case we use this plugin in 3.7 and would like to have the latest stable code. We have to fork v3.0.0-stable, change the required and then spend extra effort to support our forked branch.

I you are ok with that chnage, for your convenience I have created #19

dmitriim added a commit to catalyst/moodle-webhooks that referenced this issue Apr 21, 2020
@dmitriim
Copy link
Author

Created #18 as requested

valentineus added a commit that referenced this issue May 15, 2020
@valentineus
Copy link
Owner

Thank you, Dmitrii! Your pull requests are excellent. I released version v3.0.5 (2020051600).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants