Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clicking "Disable rule" creates a list not dictionary as expected #61

Closed
paddyroddy opened this issue Jun 18, 2020 · 1 comment
Closed

clicking "Disable rule" creates a list not dictionary as expected #61

paddyroddy opened this issue Jun 18, 2020 · 1 comment
Assignees
@valentjn
Labels
1-bug 🐛 Issue type: Bug report (something isn't working as expected) 2-confirmed Issue status: Confirmed, reproducible bug in LTeX 3-fixed Issue resolution: Issue has been fixed on the develop branch
Milestone
5.0.2

Comments

@paddyroddy
Copy link

paddyroddy commented Jun 18, 2020 •
edited
Loading

Describe the bug
When I right click and click Disable rule rather than manually editing settings.json it is not added correctly.

Steps to reproduce
Steps to reproduce the behaviour:

  1. Go to document with rule breaking
  2. Click on Disable rule
  3. Scroll down to location in settings.json
  4. See error

Expected behavior
the JSON should be like "ltex.disabledRules": {"en-GB": ["OXFORD_SPELLING_ISE_VERBS"]} but instead is like "ltex.disabledRules": ["OXFORD_SPELLING_ISE_VERBS"]

LTeX configuration
"ltex.language": "en-GB"

Version information

  • Operating system: macOS 10.15.5
  • VS Code: 1.46.0
  • vscode-ltex: 5.0.1

Additional context/information
If I'm manually editing settings.json then it disables rules as expected
@paddyroddy paddyroddy added 1-bug 🐛 Issue type: Bug report (something isn't working as expected) 2-unconfirmed Issue status: Bug that needs to be reproduced (all new bugs have this label) labels Jun 18, 2020
@valentjn valentjn added 2-confirmed Issue status: Confirmed, reproducible bug in LTeX and removed 2-unconfirmed Issue status: Bug that needs to be reproduced (all new bugs have this label) labels Jun 18, 2020
@valentjn valentjn self-assigned this Jun 18, 2020
@valentjn valentjn added this to the 5.0.2 milestone Jun 18, 2020
@valentjn valentjn added the 3-fixed Issue resolution: Issue has been fixed on the develop branch label Jun 18, 2020
@valentjn
Copy link
Owner

Thanks for the report. Fix released in 5.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valentjn valentjn

Labels
1-bug 🐛 Issue type: Bug report (something isn't working as expected) 2-confirmed Issue status: Confirmed, reproducible bug in LTeX 3-fixed Issue resolution: Issue has been fixed on the develop branch
Projects
None yet
Milestone
5.0.2
Development

No branches or pull requests
2 participants
@paddyroddy @valentjn