Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore error when setting cookies #41

Closed
wants to merge 1 commit into from

Conversation

grakic
Copy link

@grakic grakic commented Dec 10, 2019

Don't crash if site would send cookie for invalid domain

Don't crash if site would send cookie for invalid domain
@fabiante
Copy link
Collaborator

fabiante commented Jan 2, 2020

Hi @grakic, happy 2020 !
Please excuse it tooks so long to look into this.

I kind of feel like ignoring errors all the time may not be desirable.
@valeriangalliat I think we may want to add this as a property of an options parameter to the decorator function?

module.exports = function fetchCookieDecorator (fetch, jar) {

Something like:

 module.exports = function fetchCookieDecorator (fetch, jar, options) { 

@fabiante
Copy link
Collaborator

fabiante commented Jun 2, 2020

Closing in favor of #53

@fabiante fabiante closed this Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants