Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add environment variables in the configuration file #148

Merged
merged 4 commits into from
Jun 3, 2019
Merged

Add environment variables in the configuration file #148

merged 4 commits into from
Jun 3, 2019

Conversation

perzanko
Copy link
Contributor

@perzanko perzanko commented May 24, 2019 •
edited
Loading

Changelog:

  • implement custom deserialize-with methods for deserializing config::config::Config
  • add a note to the CONFIGURATION.md file

It resolves #146

This solution works only for string-like values. It can be extended in the future if it's needed.

@valeriansaliou
Copy link
Owner

Thanks a ton! Reviewing & accepting this over the weekend.
Looks good to me after giving it a quick-look, I won't make much changes to your work.

@valeriansaliou valeriansaliou self-assigned this May 24, 2019
@valeriansaliou valeriansaliou added the please review PRs that are pending review label May 24, 2019
@valeriansaliou valeriansaliou merged commit 53418d5 into valeriansaliou:master Jun 3, 2019
@valeriansaliou
Copy link
Owner

Just merged. Thanks!

@valeriansaliou valeriansaliou mentioned this pull request Apr 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@valeriansaliou valeriansaliou

Labels
please review PRs that are pending review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Channel password from environment
2 participants
@perzanko @valeriansaliou