Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding docker image for ARM #310

Merged
merged 5 commits into from
Dec 14, 2023
Merged

Conversation

PovilasID
Copy link
Contributor

Hey,

I would love to run this on ARM without having to build the container locally.
I added a tag that will build docker image for ARM based systems in parallel to x86.

@ryanccn
Copy link
Contributor

ryanccn commented Jun 25, 2023

You forgot to install QEMU and Buildx :p

@pandaninjas
Copy link
Contributor

PovilasID#1 proposed solution

@PovilasID
Copy link
Contributor Author

@ryanccn you are right ops...
@pandaninjas I have not tested it... and would have relied on github actions like so:

      -
        name: Set up QEMU
        uses: docker/setup-qemu-action@v2
      -
        name: Set up Docker Buildx
        uses: docker/setup-buildx-action@v2

but I am curious if this works so I approved the merge :)

@ryanccn
Copy link
Contributor

ryanccn commented Jun 26, 2023

@PovilasID Yeah I think you are usually supposed to be using the actions

Made a PR: PovilasID#2

ryanccn and others added 2 commits June 26, 2023 16:08
@PovilasID
Copy link
Contributor Author

@pandaninjas sorry but @ryanccn's the update looks like a more complete implementation
I just hope sonic is not dead looks like a cool project but last commit was almost 6 months ago.

@bendangelo
Copy link

Can this be merged in?

@valeriansaliou valeriansaliou merged commit 969b1b7 into valeriansaliou:master Dec 14, 2023
@valeriansaliou
Copy link
Owner

valeriansaliou commented Dec 14, 2023

So, I've merged this and the build seems to be working fine so far, but it's been 30min it's running (and still far away from finished), which is not acceptable.

I'll finish a build and release of a Sonic Docker ARM64 image as of v1.4.7 and then pull out the ARM64 builder for future versions (ie. v1.4.8), until GitHub Actions provides native ARM64 runners. Won't be using QEMU for builds unfortunately as Sonic is just too large of a project to compile over an emulator.

@PovilasID
Copy link
Contributor Author

Why does it matter how long does it build? Does it time out?
The point of this adding arm support was so we get updates easily. We can build from arm source it is just a waste of time every time if there is an update.
Also I fairly certain that with build cashing, which seams to be enabled on this project, this would be a problem only on the first container build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants