Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python=3.12 #113

Merged
merged 14 commits into from
Mar 21, 2024
Merged

Add support for Python=3.12 #113

merged 14 commits into from
Mar 21, 2024

Conversation

valeriupredoi
Copy link
Owner

@valeriupredoi valeriupredoi commented Oct 17, 2023

Closes #112

Yeh this needs to wait, bet after Christmas it'll all be dandy

All dependencies solve for and tests pass - we have full support for Python=3.12 🥳

@valeriupredoi
Copy link
Owner Author

gonna revisit imminently, things are a lot smoother Py312-wise now

@valeriupredoi valeriupredoi marked this pull request as ready for review January 12, 2024 15:19
@valeriupredoi
Copy link
Owner Author

valeriupredoi commented Jan 12, 2024

as per conda-forge/basemap-feedstock#119 and @molinav 's efforts baemap is now compatible with Python 3.12 - the only problem we now have is nctoolkit

@valeriupredoi
Copy link
Owner Author

@robertjwilson and myself are sort of discussing the 3.12 support for nctoolkit in here pmlmodelling/nctoolkit#111 - numba (as a dep for nctoolkit) is the blocker currently

@robertjwilson
Copy link

No worries @valeriupredoi . It looks like the release candidate for numba is Python 3.12 ready. However, "Numba is currently on a Winter Break", whatever that means. So just need to wait for them to decide to push a full release to pypi numba/numba#9197

@valeriupredoi
Copy link
Owner Author

cheers @robertjwilson - Winter Break sounds a bit scary - Napoleon went on such a venture in Russia and came back without an army, so hopefully they'll be back 😁

@valeriupredoi
Copy link
Owner Author

@robertjwilson good news, mate! numba has finally come back from winter break and some 29 hours ago they finally py312-ed themselves 🥳

@robertjwilson
Copy link

OK. Just need to wait for the gears to grind at conda-forge for nctoolkit to be available for 3.12, @valeriupredoi. Essentially, we need to wait for their system to automatically re-build geoviews, and then nctoolkit.

@valeriupredoi
Copy link
Owner Author

OK. Just need to wait for the gears to grind at conda-forge for nctoolkit to be available for 3.12, @valeriupredoi. Essentially, we need to wait for their system to automatically re-build geoviews, and then nctoolkit.

ya! No rush at all @robertjwilson - we needed numba to be 312-modern for another package, just wanted to drop the good news 😁

@robertjwilson
Copy link

I have finally got nctoolkit available for python 3.12 on conda forge. Let me know if everything works at your end @valeriupredoi and I will close the issue.

@valeriupredoi
Copy link
Owner Author

great news @robertjwilson cheers 🍺 Let me resurrect this one then

@valeriupredoi
Copy link
Owner Author

@ledm give this one a nod of approval pls bud, we are now modern wrt Python 🐍

Copy link
Collaborator

@ledm ledm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like nothing too crazy. Do you need me to test these on jasmin?

@valeriupredoi
Copy link
Owner Author

no not at all - if tests work then it should be fine. Cheers, bud 🍺 And cheers to @robertjwilson for his work on nctoolkit 🍺

@valeriupredoi valeriupredoi merged commit 6980a80 into main Mar 21, 2024
1 check passed
@valeriupredoi valeriupredoi deleted the python312 branch March 21, 2024 16:15
@robertjwilson
Copy link

Excellent @valeriupredoi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Python 3.12
3 participants