[v1.0.9] harden the validation code a bit

valgene · May 3, 2019 · 5894586 · 5894586
1 parent 5dedefa
commit 5894586
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## 1.0.9
+
+- more robust validation of nullable values 
+
 ## 1.0.8
 
 - migrate to pedantic package for linting

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,6 +1,6 @@
 name: valgene_cli
 description: Valgene (Validation Generator) generates validator and Dto boiler plate code from your OpenAPI specs.
-version: 1.0.8
+version: 1.0.9
 homepage: https://github.com/valgene/valgene-cli
 author: Sven Assmann <sven@d34dl0ck.me>
 

diff --git a/templates/php5.5/{{endpoint}}/{{name}}DtoValidator.php b/templates/php5.5/{{endpoint}}/{{name}}DtoValidator.php
@@ -38,6 +38,9 @@ public function validate($json)
     protected function {{ validationMethodName }}($json, $isRequired)
     {
         $field = {{ name }}Dto::{{{ asConst }}};
+        if($isRequired && !is_array($json)) {
+            throw new MissingFieldException($field, $json);
+        }
         if (!array_key_exists($field, $json)) {
             if ($isRequired) {
                 throw new MissingFieldException($field, $json);