Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/thor/unidirectional_astar.cc has an issue #4652

Closed
TheTonda opened this issue Mar 24, 2024 · 2 comments
Closed

src/thor/unidirectional_astar.cc has an issue #4652

TheTonda opened this issue Mar 24, 2024 · 2 comments

Comments

@TheTonda
Copy link
Contributor

issue : src/thor/unidirectional_astar.cc doesnt work for date_time type 2, i.e. for arrival

steps to recreate: just make any long route(idk roughly around 1500 kms) with speed_type = 2(arrival), it will say "no route found".

solution: so just update the line:

float mindist = astarheuristic_.GetDistance(origin_new);

with this one:

float mindist = astarheuristic_.GetDistance(FORWARD?origin_new:destination_new);

its a minor fix i know but installing stuff and lint checking was too much for this so I'm just gonna tell it here.

image

P.S. tell me if I can skip the guidelines for this one, and I'll raise a PR.

@kevinkreiser
Copy link
Member

im not sure what you mean by the guidelines but yeah just make a pr, we're happy for any bug fixes.

@TheTonda
Copy link
Contributor Author

okay then I hope its cool, here is my very first PR.

nilsnolde pushed a commit that referenced this issue Mar 24, 2024
…ate_time type 2, i.e. for arrival (#4653)

Co-authored-by: Kevin Kreiser <kevinkreiser@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants