We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue : src/thor/unidirectional_astar.cc doesnt work for date_time type 2, i.e. for arrival
steps to recreate: just make any long route(idk roughly around 1500 kms) with speed_type = 2(arrival), it will say "no route found".
solution: so just update the line:
float mindist = astarheuristic_.GetDistance(origin_new);
with this one:
float mindist = astarheuristic_.GetDistance(FORWARD?origin_new:destination_new);
its a minor fix i know but installing stuff and lint checking was too much for this so I'm just gonna tell it here.
P.S. tell me if I can skip the guidelines for this one, and I'll raise a PR.
The text was updated successfully, but these errors were encountered:
im not sure what you mean by the guidelines but yeah just make a pr, we're happy for any bug fixes.
Sorry, something went wrong.
okay then I hope its cool, here is my very first PR.
FIXED Issue #4652: src/thor/unidirectional_astar.cc doesnt work for d…
6fb3eb7
…ate_time type 2, i.e. for arrival (#4653) Co-authored-by: Kevin Kreiser <kevinkreiser@gmail.com>
No branches or pull requests
issue : src/thor/unidirectional_astar.cc doesnt work for date_time type 2, i.e. for arrival
steps to recreate: just make any long route(idk roughly around 1500 kms) with speed_type = 2(arrival), it will say "no route found".
solution: so just update the line:
float mindist = astarheuristic_.GetDistance(origin_new);
with this one:
float mindist = astarheuristic_.GetDistance(FORWARD?origin_new:destination_new);
its a minor fix i know but installing stuff and lint checking was too much for this so I'm just gonna tell it here.
P.S. tell me if I can skip the guidelines for this one, and I'll raise a PR.
The text was updated successfully, but these errors were encountered: