Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed trace_route edge_walk server abort by throwing default exception #1365

Merged
merged 6 commits into from
Jun 19, 2018
Merged

Fixed trace_route edge_walk server abort by throwing default exception #1365

merged 6 commits into from
Jun 19, 2018

Conversation

dgearhart
Copy link
Member

@dgearhart dgearhart commented Jun 18, 2018 •
edited
Loading

Issue

The server would abort when a trace_route using edge_walk failed. The plain thow; in the try block was not caught in the catch(...) block.

Tasklist

  • Throw default exception instead of just plain throw;
  • Add tests
  • Review - you must request approval to merge any PR to master
  • Update the changelog

@dgearhart dgearhart changed the title Fixed trace_route edge_walk server abort by throwing explicit runtime error Fixed trace_route edge_walk server abort by throwing default exception Jun 18, 2018
@dgearhart dgearhart self-assigned this Jun 18, 2018
gknisely
gknisely previously approved these changes Jun 19, 2018
View reviewed changes
@dgearhart dgearhart merged commit ae48d74 into master Jun 19, 2018
@dgearhart dgearhart deleted the edge_walk_error branch June 19, 2018 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gknisely gknisely gknisely left review comments

@dnesbitt61 dnesbitt61 Awaiting requested review from dnesbitt61

@kevinkreiser kevinkreiser Awaiting requested review from kevinkreiser

Assignees

@dgearhart dgearhart

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dgearhart @gknisely