use auto cleanup for actor in node bindings #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinkreiser
commented
Jul 24, 2018
| @@ -97,7 +97,8 @@ class Actor { | |||
| } | |||
|
|
|||
| private: | |||
| explicit Actor(const char* config) : actor(make_conf(config)), env_(nullptr), wrapper_(nullptr) { | |||
| explicit Actor(const char* config) | |||
| : actor(make_conf(config), true), env_(nullptr), wrapper_(nullptr) { | |||
There was a problem hiding this comment.
auto-cleanup defaults to false. this is useful if you are some kind of service that wants explicit control over when you do cleanup. for example, if you want to be as fast as possible for your requesters, you probably want to call cleanup only after you've returned the response to them (this is how prime_server works). depending on the size of the request it shaves that extra little bit latency off the response time.
allierowan
previously approved these changes
Jul 25, 2018
allierowan
approved these changes
Jul 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The node bindings weren't using the auto-cleanup function for the
actor_tobject. since we are most of the way through the request to pbf refactor this didnt matter too much, but some of the stuff in the refactor isnt all the way done. what this means is that for each request there is some state left around inthor::worker_tfor example. simultaneously,actor_tdefaults auto-cleanup tofalse. by setting it totruewe make sure to clear out this state on every request. this wont be a problem once request state lives in the pbf request object. for now we are in a bit of an in between where some of it is still within the worker classes