Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix opposing edge indexes for loops #1576

Merged
merged 10 commits into from
Oct 11, 2018
Merged

Fix opposing edge indexes for loops #1576

merged 10 commits into from
Oct 11, 2018

Conversation

dnesbitt61
Copy link
Member

@dnesbitt61 dnesbitt61 commented Oct 10, 2018 •
edited
Loading

  • Review - you must request approval to merge any PR to master
  • Add #fixes with the issue number that this PR addresses
  • Generally use squash merge to rebase and clean comments before merging
  • Update the changelog

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

@dnesbitt61
Add max_timedep_distance for time dependent (not multi-modal) routes.…
b8e4c71 
… Used

to select the path algorithm - above this configured distance bidirectional A* is used.
@dnesbitt61
Add max_timedep_distance to worker. Get this value from the config. S…
e5d6d2d 
…kip service

limits with this string (in thor and loki when getting costing dependent config
values).
@dnesbitt61
Remove unused variable (max_shortcut_length).
3acbff0
@dnesbitt61
Use max_timedep_distance in valhalla_run_route
7695d48
@dnesbitt61
Merge branch 'master' of github.com:valhalla/valhalla
8548476
@dnesbitt61
Move shapes_match method to util so it can be shared by GraphEnhancer…
3d32c4b 
… and GraphValidator.
@dnesbitt61
Move ShapesMatch to util and use this shared method (now renamed shap…
a71d147 
…es_match).
@dnesbitt61
Update GetOpposingEdgeIndex to use similar logic to that in GraphVali…
b593922 
…dator. It is not

sufficient to match end node and length - need to verify shape matches as there are
loop cases that have 2 edges matching end node and length. If the end nodes of the
opposing edges are in the same tile it is sufficient to compare the edgeinfo offset.
If they are not in the same tile then shape comparison is needed (could be the shape
points are reversed for the 2 edges - so shapes_match checks that).
@dnesbitt61 dnesbitt61 merged commit 2ffec21 into master Oct 11, 2018
@dnesbitt61 dnesbitt61 deleted the loop_fix branch October 11, 2018 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gknisely gknisely gknisely approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dnesbitt61 @gknisely