Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created install script for Ubuntu:18.04 Bionic #1692

Merged
merged 4 commits into from
Jan 28, 2019

Conversation

jendrusk
Copy link
Contributor

I was trying to install Valhalla on Bionic and I faced several issues... finally I made it, so this is my script - you can link it in your documentation - could be handy. You can test it using lxc container with ubuntu:18.04 - after few minutes you should get ready to use container :)

Issue

#1630

Tasklist

  • Add tests
  • Review - you must request approval to merge any PR to master
  • Add #fixes with the issue number that this PR addresses
  • Generally use squash merge to rebase and clean comments before merging
  • Update the changelog
  • Update relevant documentation

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

I was trying to install Valhalla on Bionic and I faced several issues... finally I made it, so this is my script - you can link it in your documentation - could be handy. You can test it using lxc container with ubuntu:18.04 - after few minutes you should get ready to use container :)
Created install script for Ubuntu:18.04 Bionic
@jendrusk
Copy link
Contributor Author

Fixed :)
It's my first pool-request ever, so if anything is wrong please let me know :)

@dnesbitt61
Copy link
Member

Might also want to add this in the data building section:

ln -s /usr/lib/x86_64-linux-gnu/mod_spatialite.so /usr/lib/x86_64-linux-gnu/mod_spatialite

This issue describes the need for special handling for sqlite load_extension in 18.0.4: #1437

@kevinkreiser
Copy link
Member

@dnesbitt61 about mod_spatialite, maybe we should have the code do the fallback instead of forcing the user to create a symlink. this would be nicer imho and would be a small amount of code i think!?

@dnesbitt61
Copy link
Member

not sure how to do this, but if you walk me through it I can try later. It just seemed that others already have gone through the process of creating the symlink so figured that was the desired approach.

@kevinkreiser
Copy link
Member

@dnesbitt61 we would just need to add a retry in the if that checks the return code of the module loading query. i'll open another issue for this! dont let me stop you guys merging this.

@dnesbitt61 dnesbitt61 merged commit bb46d81 into valhalla:master Jan 28, 2019
@dnesbitt61
Copy link
Member

@jendrusk thanks for the PR! I am going to move this to the scripts directory and place a link to it in the Readme.

@jendrusk
Copy link
Contributor Author

I'm glad I could help. :)

@erictheise
Copy link

Your script works flawlessly @jendrusk. Big thanks to you for contributing it to the project!

@erictheise
Copy link

I may have spoken too soon. Following the steps in Running I experience

$ valhalla_service valhalla.json 1
valhalla_service: error while loading shared libraries: libprime_server.so.0: cannot open shared object file: No such file or directory
$

although it's sitting right there in /usr/local/lib/.

@kevinkreiser
Copy link
Member

Is that location on your LD_LIBRARY_PATH?

@ptodorov0
Copy link

Had the same problem on a fresh 18.04. Installed using the Ubuntu_Bionic_Install.sh script. Fixed it by running
export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/usr/local/lib/

Thanks for the suggestion, @kevinkreiser

It will be nice if this fix is added to the Ubuntu_Bionic_Install.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants