Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix osrm maneuver type for to_stay_on steps #1714

Merged
merged 6 commits into from Feb 8, 2019
Merged

Fix osrm maneuver type for to_stay_on steps #1714

merged 6 commits into from Feb 8, 2019

Conversation

dgearhart
Copy link
Member

@dgearhart dgearhart commented Feb 8, 2019 •
edited

Issue

Currently, the osrm maneuver type is set to turn instead of continue for a to_stay_on step.

Tasklist

  • Update logic to properly assign the continue maneuver type
  • Add tests
  • Review - you must request approval to merge any PR to master
  • Generally use squash merge to rebase and clean comments before merging
  • Update the changelog

Before

before_to_stay_on

After

after_to_stay_on

@dgearhart dgearhart self-assigned this Feb 8, 2019
dnesbitt61
dnesbitt61 approved these changes Feb 8, 2019
View reviewed changes
Copy link
Member

@dnesbitt61 dnesbitt61 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :shipit:

@dgearhart dgearhart merged commit 543f876 into master Feb 8, 2019
@dgearhart dgearhart deleted the gdg_to_stay_on branch February 8, 2019 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnesbitt61 dnesbitt61 dnesbitt61 approved these changes

Assignees

@dgearhart dgearhart

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dgearhart @dnesbitt61