Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rotary/roundabout issues in Valhalla OSRM compatibility #1727

Merged
merged 6 commits into from
Feb 25, 2019
Merged

Rotary/roundabout issues in Valhalla OSRM compatibility #1727

merged 6 commits into from
Feb 25, 2019

Conversation

dgearhart
Copy link
Member

@dgearhart dgearhart commented Feb 25, 2019 •
edited
Loading

Issue

Missing rotary name & type
Incorrect roundabout exit street name
Investigate and fix the Valhalla OSRM compatibility logic

Tasklist

  • Add tests
  • Review - you must request approval to merge any PR to master
  • Generally use squash merge to rebase and clean comments before merging
  • Update the changelog

@dgearhart dgearhart self-assigned this Feb 25, 2019
@dgearhart dgearhart merged commit 444e931 into master Feb 25, 2019
@dgearhart dgearhart deleted the gdg_roundabout_name branch February 25, 2019 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnesbitt61 dnesbitt61 dnesbitt61 approved these changes

Assignees

@dgearhart dgearhart

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dgearhart @dnesbitt61