Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the destinations assignment for exit names in OSRM compatibility mode #1732

Merged
merged 2 commits into from
Mar 1, 2019
Merged

Fixed the destinations assignment for exit names in OSRM compatibility mode #1732

merged 2 commits into from
Mar 1, 2019

Conversation

dgearhart
Copy link
Member

@dgearhart dgearhart commented Mar 1, 2019 •
edited
Loading

Issue

Exit names should only be used if exit branch and exit toward records are empty. Fixed the destinations assignment for the OSRM compatibility mode.

Tasklist

  • Review - you must request approval to merge any PR to master
  • Generally use squash merge to rebase and clean comments before merging
  • Update the changelog

In the following example - Bedford should not be part of the destinations

Before

destinations_name_before

After

destinations_name_after

@dgearhart dgearhart self-assigned this Mar 1, 2019
@dgearhart dgearhart requested a review from gknisely March 1, 2019 21:29
@dgearhart dgearhart merged commit dd51d44 into master Mar 1, 2019
@dgearhart dgearhart deleted the gdg_fix_destination_names branch March 1, 2019 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gknisely gknisely gknisely approved these changes

Assignees

@dgearhart dgearhart

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dgearhart @gknisely