Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance merge maneuver type assignment #1735

Merged
merged 6 commits into from
Mar 7, 2019
Merged

Enhance merge maneuver type assignment #1735

merged 6 commits into from
Mar 7, 2019

Conversation

dgearhart
Copy link
Member

@dgearhart dgearhart commented Mar 7, 2019

Issue

While testing the OSRM compatibility mode - noticed some inconsistent assignments for the merge maneuver type. Added logic to provide consistent assignments.

Example 1
< BEFORE
< Continue on 17th Street.
> AFTER
> Merge onto 17th Street.

Example 2
< BEFORE
< Continue on PA 743 North.
> AFTER
> Merge onto PA 743 North.

Example 3
< BEFORE
< Merge left onto US 220 Business
> AFTER
> Turn left onto US 220 Business

Tasklist

  • Test
  • Review - you must request approval to merge any PR to master
  • Generally use squash merge to rebase and clean comments before merging
  • Update the changelog

@dgearhart dgearhart self-assigned this Mar 7, 2019
@dgearhart dgearhart merged commit 43d0ed1 into master Mar 7, 2019
@dgearhart dgearhart deleted the gdg_merge branch March 7, 2019 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants