Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pedestrian option adjustments #1746

Merged
merged 27 commits into from Apr 26, 2019
Merged

Pedestrian option adjustments #1746

merged 27 commits into from Apr 26, 2019

Conversation

kdiluca
Copy link
Member

@kdiluca kdiluca commented Mar 19, 2019

Issue

What issue is this PR targeting? If there is no issue that addresses the problem, please open a corresponding issue and link it here.

Tasklist

  • Add tests
  • Review - you must request approval to merge any PR to master
  • Add #fixes with the issue number that this PR addresses
  • Generally use squash merge to rebase and clean comments before merging
  • Update the changelog
  • Update relevant documentation

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

@kdiluca kdiluca added the WIP label Mar 19, 2019
@kdiluca kdiluca self-assigned this Mar 19, 2019
@kdiluca
Copy link
Member Author

kdiluca commented Apr 3, 2019

I'd like to be able to merge this to master so that @dgearhart can do some RAD testing. Also, it's been awhile since we've tagged a release so we'll need to update the change log for this as well.

@kdiluca
Copy link
Member Author

kdiluca commented Apr 4, 2019

Pedestrian Diffs: (pedestrian_routes.txt)
Valhalla With sidewalk adjustment, no walkway_factor:
#87
image
image
vs.
Valhalla With sidewalk adjustment, walkway_factor=1.5:
#88
image
image
image

Valhalla With sidewalk adjustment, no walkway_factor:
#90
image
image
vs.
Valhalla With sidewalk adjustment, walkway_factor=1.5:
#91
image
image

@kdiluca kdiluca merged commit 6cd90e3 into master Apr 26, 2019
@kdiluca kdiluca deleted the kdiluca-pedestrian branch May 29, 2019 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants