Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for pedestrian forks, pedestrian roundabouts, and continue maneuvers #1768

Merged
merged 8 commits into from
Apr 18, 2019

Conversation

dgearhart
Copy link
Member

@dgearhart dgearhart commented Apr 18, 2019

Issue

  1. Need to improve pedestrian guidance for the following:

    • Forks
    • Roundabouts
  2. Also, improve guidance when continuing straight and not needing to turn

This PR adds logic to detect and announce forks for pedestrians. This improves some of the items discussed in #1761
This PR removed the enter/exit roundabout announcements for pedestrians - please see examples below.
This PR fixed #1533 by announcing continue instead of bear left or right when continuing straight through an intersection.
This PR fixed the to stay on announcement for forks

Pedestrian fork example

Maneuver#4 is new - now the user knows to keep right at the fork in the walkway
image

Pedestrian roundabout example#1

< BEFORE
< 2: Continue on US 30 West/East King Street.
< 3: Enter the roundabout and take the 1st exit.
< 4: Exit the roundabout onto North Queen Street/PA 194.
> AFTER
> 2: Keep right to stay on US 30 West.
> 3: Keep right to take North Queen Street/PA 194.

image

Pedestrian roundabout example#2

< BEFORE
< 2: Enter the roundabout and take the 1st exit.
< 3: Exit the roundabout onto US 30/Lincoln Way West.
> AFTER
> 2: Turn right onto US 30/Center Square.
> 3: Turn right onto US 30/Lincoln Way West.

image

Bear vs. straight example#1

< BEFORE
< 2: Bear left onto Hockersville Road.
> AFTER
> 2: Continue on Hockersville Road.

image

Bear vs. straight example#2

< BEFORE
< 2: Bear right onto Colonial Road.
> AFTER
> 2: Continue on Colonial Road.

image

Tasklist

  • Test
  • Add before and after examples
  • Review - you must request approval to merge any PR to master
  • Add #fixes with the issue number that this PR addresses
  • Generally use squash merge to rebase and clean comments before merging
  • Update the changelog

@dgearhart dgearhart self-assigned this Apr 18, 2019
@dgearhart dgearhart requested a review from kdiluca April 18, 2019 20:10
@dgearhart dgearhart merged commit ffb4145 into master Apr 18, 2019
@dgearhart dgearhart deleted the gdg_bear_staight_ped_roundabouts branch April 18, 2019 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bear vs. straight
2 participants