Do not use surface type in bicycle edge filter #1800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enalize poor surfaces based on the avoid_bad_surfaces option)
gknisely
previously approved these changes
May 9, 2019
|
@dnesbitt61 can you merge master and update the changelog |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, rely on EdgeCost to penalize poor surfaces based on the avoid_bad_surfaces option. There have been issues where a route can be created that takes an unpaved road (using a road bicycle) but any reroute while on the unpaved road will fail due to the edge filter excluding such roads entirely.
fixes #1799
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?