Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added logic to detect if user is to merge to the left or right #1892

Merged
merged 5 commits into from
Jul 24, 2019

Conversation

dgearhart
Copy link
Member

@dgearhart dgearhart commented Jul 23, 2019

Issue

The OSRM compatibility mode expects merge maneuvers to have an associated modifier. The modifier indicates if the user should merge to the left or to the right.
Fixes #1730

Examples of before vs. after - these were in the issue

merge_1_before_vs_after

image

Another Example before vs. after

image
image

Tasklist

  • Test
  • Review - you must request approval to merge any PR to master
  • Generally use squash merge to rebase and clean comments before merging
  • Update the changelog

@dgearhart dgearhart self-assigned this Jul 23, 2019
@@ -1,3 +1,7 @@
## Release Date: UNRELEASED Valhalla 3.0.8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to update the header with the new version

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we do that when re release it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NM we'll make a release later!

@dgearhart dgearhart merged commit 9628524 into master Jul 24, 2019
@dgearhart dgearhart deleted the gdg_merge_dir branch July 24, 2019 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix merge directional for OSRM Compatibility mode [1]
2 participants